Add Dotty error messages post #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping: @SethTisue |
sjrd
reviewed
Oct 14, 2016
|
|
||
| It doesn't really make sense to put this in a `try`-block for two reasons: | ||
|
|
||
| 1. It doesn't throw an exception |
There was a problem hiding this comment.
This part is irrelevant to the present discussion. I suggest you replace 1 + 2 by foo(), and let the reader figure out that foo() might throw an exception.
|
|
||
| This is helpful, but it has a couple of drawbacks: | ||
|
|
||
| 1. If we have a bazillion errors, it will be hard to read |
There was a problem hiding this comment.
Yes - the new errors have division between errors so you can see where one ends and another begins.
| 2. Read the howto on error messages | ||
| 3. Choose an error message you want to help with and post a comment saying | ||
| which one(s) | ||
| 4. Get hacking! |
felixmulder
force-pushed
the
topic/post-dotty-errors
branch
from
93efc2e to
3ae06c7
Compare
|
👏 Can I merge this now? |
|
Well OK, I'm doing it :) |
what's the equivalent of "the squeaky wheel gets the grease", but for the person who oils the wheels? "the squeaky wheel only squeaks when the guy with the oil can walks by"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
We'd like to add this post on dotty error messages to the blog.
Cheers,
Felix